properly output esm #1331
Merged
properly output esm #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dfce529 The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
turbocrime
force-pushed
the
turbocrime/esm-extensions
branch
from
525c3bf
to
49c2911
Compare
turbocrime
force-pushed
the
turbocrime/esm-extensions
branch
from
49c2911
to
c98029f
Compare
turbocrime
commented
Jun 18, 2024
TalDerei
approved these changes
Jun 18, 2024
turbocrime
commented
Jun 18, 2024
turbocrime
force-pushed
the
turbocrime/esm-extensions
branch
from
81cf3ca
to
ac85998
Compare
TalDerei
approved these changes
Jun 19, 2024
turbocrime
force-pushed
the
turbocrime/esm-extensions
branch
from
ac85998
to
dfce529
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uses
tsc-aliasto generate correct import paths for esm supportthis may have been related to issues @VanishMax was experiencing
this should permit esm resolution to work properly for the packages' internal modules
edit: okay, tsc-alias doesn't completely solve the issue -
bundlers are fine now, but anything that needs to use node module resolution (vitest, many consumers) will encounter problems because our packages currently use nonstandard module resolution to identify imports from external dependencies.
the tsc-alias tool is only indended for internal paths.
probably we should just comply with esm path spec internally, but that would require changing nearly every import in the codebase, so this PR now combines tsc-alias and changes imports to name external 'js' files that are not resolved via package.json exports.
this mainly just means pb types imports now require a 'js' extension, because those generated packages don't actually define any exports or main configuration.
there's hundreds of pb type imports, so it's a large diff. but this means we don't have to configure a bundler for every package, and the packages should have much better support for many consumers.
edit again:
instead of literally modifying imports, now mutating in a more custom way
this solution is bad. eventually a larger linter/bundler reconfig should happen